Ignore orphan scopes #290
Merged
Ignore orphan scopes #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orphan scopes are the scopes that do not ultimately end at a subclass of `RootComponent`. This means they are detached and therefore cannot be provided for. This change ignores parsing these orphans. Also updated samples and documentation to reflect this new root API change.
rudro
approved these changes
May 8, 2019
| return ancestorPaths(for: component) | ||
| .map { (path: [Component]) -> DependencyProvider in | ||
| return DependencyProvider(path: path, dependency: component.dependency) | ||
| .filter { !$0.isEmpty } |
There was a problem hiding this comment.
nit: this filter is pretty much the guard let + compactMap combo in the next 3 lines.
There was a problem hiding this comment.
Yeah you are right. The downside is I can't remove the guard since first returns optional. And of course we need the compactMap.
Generator/Sources/NeedleFramework/Generating/DependencyProviderDeclarerTask.swift
Outdated
Show resolved
Hide resolved
|
Travis is not reporting back but everything actually passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orphan scopes are the scopes that do not ultimately end at a subclass of
RootComponent. This means they are detached and therefore cannot be provided for. This change ignores parsing these orphans.Also updated samples and documentation to reflect this new root API change.
Fixes #272