Run e2e tests in docker and Buildkite #95
Conversation
| @@ -1,10 +1,54 @@ | |||
| version: '3' | |||
| version: '2.1' | |||
There was a problem hiding this comment.
Just testing for now, this allows us to use some syntax in regards to services dependencies in docker that we have working in our browser-tests repo. Will try to upgrade assuming we get this working. This is not ready to go yet, still running into weird selenium issues when running on linux.
There was a problem hiding this comment.
Got this working for now, so I think I'd like to go ahead and land as-is. We can coordinate the docker-compose version upgrade along with the browser-tests repo which will make things easier: https://github.com/fusionjs/browser-tests/blob/master/docker-compose.yml#L1
KevinGrandon
force-pushed
the
e2e-docker
branch
from
2c10a03
to
5784217
Compare
KevinGrandon
force-pushed
the
e2e-docker
branch
2 times, most recently
from
84e9819
to
1896d9d
Compare
KevinGrandon
changed the title
KevinGrandon
force-pushed
the
e2e-docker
branch
from
1896d9d
to
05ea87c
Compare
|
I got this passing, then rebased and now it's failing 😭 Going to look into these test failures later this week. |
|
Yeap, our e2e tests are broken on master. It is not flaky anymore it is broken. |
Thanks, good to know. Landing this should prevent us from breaking tests permanently in the future. Might be worth disabling the test if we don't have a quick fix it to get this landed. |
|
KevinGrandon
force-pushed
the
e2e-docker
branch
from
05ea87c
to
a984bde
Compare
| @@ -33,7 +33,7 @@ run((driver, browser) => { | |||
| runBrowserAccecibilityTest(driver, 'label'); | |||
| }); | |||
|
|
|||
| test('Checked state', async function() { | |||
| test.skip('Checked state', async function() { | |||
There was a problem hiding this comment.
I think this is fine for now.
|
Beautiful! Thank you for doing this! |
Adds support for running integration tests in docker containers.