Terminate timeloop faster for m3 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rabbbit
approved these changes
Oct 7, 2022
prashantv
reviewed
Oct 10, 2022
|
Production tests fail with errors that timeLoop goroutine is leaking, investigating, I suspect that production is not always properly discarding tally |
|
So it seems code is correct, indeed there are a lot of leaking goroutines because tally reporter is not properly closed. So this change potentially can introduce regression for tests which try to detect leaking goroutines. |
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 47.31% 47.36% +0.04%
==========================================
Files 64 64
Lines 5932 5937 +5
==========================================
+ Hits 2807 2812 +5
Misses 2685 2685
Partials 440 440
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mway
reviewed
Oct 10, 2022
mway
reviewed
Oct 10, 2022
brawndou
pushed a commit
to brawndou/tally
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We quickly start and stop process (it is wrapper for another command) and timeloop potentially can delay process shutdown by up-to 100ms (_timeResolution). Instead of just sleeping we as well wait for signal that shutdown is in progress and quickly terminate loop.