ENH: level 2 grid work/plotting #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add some code to plot/debug the level 2 grid and its center points * currently, there seem to be a few (possible) issues here: - some of the level 2 grid centers appear to be way too far away from the input spherical polygon where the smaller level 2 cells should be showing up, perhaps because of "wrapping" issues near angle boundaries (+/- 90 or +/- 180 perhaps) - I need to re-read some parts of the paper to make sure that it is "ok" that some level 2 grid cells are smaller than others (i.e., the corner where extra input polygon edges intersect a cell)
tylerjereddy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 99.36% 92.21% -7.15%
==========================================
Files 1 1
Lines 313 334 +21
==========================================
- Hits 311 308 -3
- Misses 2 26 +24
Continue to review full report at Codecov.
|
* it seems the longitude transition point code in `convert_cartesian_to_lat_long()` function was causing issues with L2 grid cell placements near transition points; deactivating it produces a much more reasonable level 2 grid plot * some `pycodestyle` cleanups * the overall grid plot looks more sensible now too
tylerjereddy
changed the title
|
Updated results for the level 2 and overall grid look more solid now than ever before (see below). Let me revisit my question about the corner resolution at a given level later.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some code to plot/debug the level 2
grid and its center points
currently, there seem to be a few (possible) issues here:
way too far away from the input spherical polygon
where the smaller level 2 cells should be showing up,
perhaps because of "wrapping" issues near angle boundaries
(+/- 90 or +/- 180 perhaps)
that it is "ok" that some level 2 grid cells are smaller
than others (i.e., the corner where extra input polygon
edges intersect a cell)