This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Fixed Storm stats bug with Promise #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianoc
added a commit
that referenced
this pull request
May 22, 2014
Fixed Storm stats bug with Promise
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
…sherspec Fix flaky `MinHasherSpec` test. Fixes twitter#500
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StormStatProviders were getting GCed, made it a global object and it is initialized using a Promise