This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Feature/storm new planner #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Intermediate/Final flat map distinction
…into feature/storm_new_planner Conflicts: summingbird-core/src/test/scala/com/twitter/summingbird/TestGraphGenerators.scala
| store.asInstanceOf[StoreFactory[K, W]]) | ||
|
|
||
| def foldOperations(producers: List[Producer[Storm, _]]): FlatMapOperation[Any, Any] = { | ||
| producers.foldLeft(FlatMapOperation.identity[Any]) { |
There was a problem hiding this comment.
we need to make sure andThen on identity is free. We need to override andThen on the identity to just return the right hand argument.
| // We also drop all StormNodes with no members(may occur when we visit a node already seen and its the first in that Node) | ||
| val revsersedNodeSet = stormNodeSet.filter(_.members.size > 0).foldLeft(List[StormNode]()){(nodes, n) => n.reverse :: nodes} | ||
| // We also drop all Nodes with no members(may occur when we visit a node already seen and its the first in that Node) | ||
| val revsersedNodeSet = stormNodeSet.filter(_.members.size > 0).foldLeft(List[Node]()){(nodes, n) => n.reverse :: nodes} |
There was a problem hiding this comment.
is that reveresedNodeSet?
|
@johnynek since this is all refactored around a in the other open PR i put the spellcheck name into the other one |
| def dependantsOf(n: StormNode): List[StormNode] = dependsOnM.get(n).getOrElse(List()) | ||
| def dependsOn(n: StormNode): List[StormNode] = dependantOfM.get(n).getOrElse(List()) | ||
| def dependantsOf(n: Node): List[Node] = dependsOnM.get(n).getOrElse(List()) | ||
| def dependsOn(n: Node): List[Node] = dependantOfM.get(n).getOrElse(List()) |
There was a problem hiding this comment.
rename dependsOn to dependenciesOf?
Also, the right hand side looks reversed. Is it right? Can you explain this in a comment?
| // TODO (https://github.com/twitter/summingbird/issues/86): | ||
| // support topologies that don't end with a sum | ||
| populate(topologyBuilder, summer, name) | ||
| stormDag.nodes.map { node => |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storm platform now uses the newly generated graphs