Fixed bug in dropdown toggle where menu would only clear on the first dropdown #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fix my pull request Erlen :) |
|
No problem :) I ran into the same problem and decided to just extract my non working code as a test case, hopefully they will merge it into the next release! -Erlend On Sep 27, 2012, at 3:02 PM, Gustavo Warmling Teixeira wrote:
|
fat
added a commit
that referenced
this pull request
Oct 18, 2012
Fixed bug in dropdown toggle where menu would only clear on the first dropdown
|
thanks for the unit test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[resubmitted, (hopefully) in accordance with the pull request guidelines]
This is an expansion on #5220
I've added gustavowt's fix and a test case that covers the bug.
See original here: #5288