-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify code for 'cover' example using utility classes #28986
Conversation
We can remove this in favor of the We can use the This css is overridden by We can use the responsive float classes here: We can use |
Plus the |
thanks for the good feedback @XhmikosR and @MartijnCuppens . I've further simplified the CSS and HTML. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more changes to simplify just a bit more, plus some nits :D.
Not really a big deal or anything, but can this one be backported to v4? I saw many of the other example code updates were backported so thought this might be worth doing too. |
We switched from jekyll to Hugo, so I don't know if we can just cherrypick this. |
Yeah, it didn't apply clean that's why I didn't cherry pick it. |
This reduces the size of the CSS and (I think) makes the example source code easier to read.
Note; the
background-color
is very slightly different as I usedbg-dark
.https://deploy-preview-28986--twbs-bootstrap.netlify.com/docs/4.3/examples/cover/