Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code for 'cover' example using utility classes #28986

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Simplify code for 'cover' example using utility classes #28986

merged 2 commits into from
Jul 22, 2019

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 4, 2019

This reduces the size of the CSS and (I think) makes the example source code easier to read.

Note; the background-color is very slightly different as I used bg-dark.

https://deploy-preview-28986--twbs-bootstrap.netlify.com/docs/4.3/examples/cover/

@coliff coliff requested a review from a team as a code owner July 4, 2019 08:12
@XhmikosR
Copy link
Member

XhmikosR commented Jul 4, 2019

Plus the .cover styles minus the button's vertical padding.

@coliff
Copy link
Contributor Author

coliff commented Jul 4, 2019

thanks for the good feedback @XhmikosR and @MartijnCuppens . I've further simplified the CSS and HTML.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes to simplify just a bit more, plus some nits :D.

site/content/docs/4.3/examples/cover/index.html Outdated Show resolved Hide resolved
site/content/docs/4.3/examples/cover/index.html Outdated Show resolved Hide resolved
site/content/docs/4.3/examples/cover/index.html Outdated Show resolved Hide resolved
@XhmikosR XhmikosR merged commit 6bebd29 into twbs:master Jul 22, 2019
@coliff
Copy link
Contributor Author

coliff commented Dec 6, 2019

Not really a big deal or anything, but can this one be backported to v4? I saw many of the other example code updates were backported so thought this might be worth doing too.

@MartijnCuppens
Copy link
Member

We switched from jekyll to Hugo, so I don't know if we can just cherrypick this.

@XhmikosR
Copy link
Member

XhmikosR commented Dec 6, 2019

Yeah, it didn't apply clean that's why I didn't cherry pick it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants