Update browser compatibility note for position: sticky (Edge supports it now) #25229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest shipping version of Edge supports position: sticky and I've successfully tested it with Bootstrap 4 and it works as intended. I added IE10 in place of Edge in that note as I assume that IE10 also has the `position: relative` fallback. REF: https://caniuse.com/#search=sticky
mdo
approved these changes
Jan 10, 2018
docs/4.0/utilities/position.md
Outdated
| @@ -38,7 +38,7 @@ Position an element at the bottom of the viewport, from edge to edge. Be sure yo | |||
|
|
|||
| Position an element at the top of the viewport, from edge to edge, but only after you scroll past it. The `.sticky-top` utility uses CSS's `position: sticky`, which isn't fully supported in all browsers. | |||
|
|
|||
| **Microsoft Edge and IE11 will render `position: sticky` as `position: relative`.** As such, we wrap the styles in a `@supports` query, limiting the stickiness to only browsers that properly can render it. | |||
| **IE11 and IE10 will render `position: sticky` as `position: relative`.** As such, we wrap the styles in a `@supports` query, limiting the stickiness to only browsers that properly can render it. | |||
There was a problem hiding this comment.
"that properly can render it" > "that can render it properly" ?
There was a problem hiding this comment.
Agreed that "that can render it properly" would read better.
There was a problem hiding this comment.
Works for me! Feel free to (force) push a change for that and we can merge as soon as CI stuff gets sorted.
patrickhlauke
approved these changes
Jan 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest shipping version of Edge supports position: sticky and I've successfully tested it with Bootstrap 4 and it works as intended. I added IE10 in place of Edge in that note as I assume that IE10 also has the
position: relativefallback.REF: https://caniuse.com/#search=sticky