Bump notify to 5.0.0-pre.13 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@netthier thanks for the PR! Sounds like a solid update. The thing to do with the changelog would be to just add a description of your change under the https://github.com/thedodd/trunk/blob/master/CHANGELOG.md#unreleased section. Once it is time to cut a release, I will move items around to place them under the correct heading based on the accumulated set of changes. |
thedodd
requested changes
Oct 5, 2021
|
I hope this is fine, I wasn't sure what exactly to write. |
|
I accidentally wrote 0.5.0 instead of 5.0.0, this needs to be squashed |
thedodd
previously approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I wasn't sure if I should create a new 0.14.1 section in the changelog for a change this small.
This PR bumps the version of notify to
5.0.0-pre.13.Currently, trunk is barely useable on *BSD systems, as the kqueue implementation provided in the currently used
5.0.0-pre.11contains a call todbg!()...This leads to the console being absolutely spammed with these debug messages, making the actual trunk output impossible to find.
The bug was fixed in
5.0.0-pre.13, hence this PR.Related:
notify-rs/notify#356
notify-rs/notify#357
(Also, should this PR be accepted, I'd appreciate the
hacktoberfest-acceptedlabel, more about it here