Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve concepts and related doc sections #22595

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jul 5, 2024

Description

  • Add client
  • Update data sources
  • Add links to website
  • Modernize content
  • Update clients overview page
  • Fix issues in related client protocol docs

Additional context and related issues

Also fixes some minor grammar and style issues in client protocol page in separate commit.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link
Contributor

@m57lyra m57lyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff to fix, esp missing link texts

docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/develop/client-protocol.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/overview/concepts.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/overview/concepts.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/overview/concepts.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/overview/concepts.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/overview/concepts.md Outdated Show resolved Hide resolved
@mosabua mosabua changed the title Improve concepts documentation Improve concepts and related documentation Jul 5, 2024
@mosabua mosabua changed the title Improve concepts and related documentation Improve concepts and related doc sections Jul 5, 2024
@mosabua mosabua requested a review from electrum July 5, 2024 21:02
@mosabua mosabua force-pushed the concepts branch 2 times, most recently from 635b4dd to 2130e32 Compare July 8, 2024 18:55
@mosabua
Copy link
Member Author

mosabua commented Jul 8, 2024

All comments addressed @m57lyra

docs/src/main/sphinx/client.md Outdated Show resolved Hide resolved
@mosabua mosabua force-pushed the concepts branch 2 times, most recently from 83a677c to 0560e02 Compare July 8, 2024 23:13
- Add client
- Update data sources
- Add links to website
- Modernize content
- Update clients overview page
- Improve client protocol page
- Fix minor grammar and style issues
@mosabua
Copy link
Member Author

mosabua commented Jul 19, 2024

Thank you for the review and approval @raunaqmorarka

@mosabua mosabua merged commit f9047ef into trinodb:master Jul 19, 2024
9 checks passed
@mosabua mosabua deleted the concepts branch July 19, 2024 21:12
@github-actions github-actions bot added this to the 453 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants