-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve concepts and related doc sections #22595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
concepts
branch
2 times, most recently
from
July 5, 2024 19:56
6f2bb17
to
ba58b89
Compare
m57lyra
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff to fix, esp missing link texts
mosabua
changed the title
Improve concepts documentation
Improve concepts and related documentation
Jul 5, 2024
mosabua
changed the title
Improve concepts and related documentation
Improve concepts and related doc sections
Jul 5, 2024
mosabua
force-pushed
the
concepts
branch
2 times, most recently
from
July 8, 2024 18:55
635b4dd
to
2130e32
Compare
All comments addressed @m57lyra |
dain
reviewed
Jul 8, 2024
mosabua
force-pushed
the
concepts
branch
2 times, most recently
from
July 8, 2024 23:13
83a677c
to
0560e02
Compare
- Add client - Update data sources - Add links to website - Modernize content - Update clients overview page - Improve client protocol page - Fix minor grammar and style issues
raunaqmorarka
approved these changes
Jul 19, 2024
Thank you for the review and approval @raunaqmorarka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Also fixes some minor grammar and style issues in client protocol page in separate commit.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.