Change nulls array in all blocks from boolean[] to byte[] #22586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * This method is used to perform that conversion until the Block implementations are changed. | ||
| */ | ||
| static Optional<ByteArrayBlock> getNulls(@Nullable boolean[] valueIsNull, int arrayOffset, int positionCount) | ||
| static Optional<ByteArrayBlock> getNulls(@Nullable byte[] valueIsNull, int arrayOffset, int positionCount) |
There was a problem hiding this comment.
Nice, please also simplify IsNullColumnarFilter and IsNotNullColumnarFilter to not do the extra mayHaveNull check. I realised now that it was unnecessary.
wendigo
reviewed
Jul 5, 2024
core/trino-spi/src/main/java/io/trino/spi/block/Int128ArrayBlockBuilder.java
Show resolved
Hide resolved
|
Change seems mostly mechanical. We should get this in. |
dain
force-pushed
the
block-nulls-byte-array
branch
from
4cf9f40
to
659a613
Compare
|
Looks nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change nulls array in all blocks from boolean[] to byte[]. Boolean array type is not very well supported in MemorySegment or vector APIs.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: