Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Application Default Credential if gcp.credential is absent #1585

Merged
merged 8 commits into from
Jun 4, 2021
+113 −5
Merged

Use Application Default Credential if gcp.credential is absent #1585

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f4a56f
use application default credential if gcp.credential is absent
rhase Feb 2, 2021
e94de34
fixed indentation
rhase Feb 4, 2021
d229ce8
add test
rhase Feb 16, 2021
65646da
fix indentation
rhase Feb 16, 2021
814cbc5
bugfix
rhase Feb 16, 2021
d570090
consideration for windows
rhase Feb 16, 2021
7e5ce80
organize imports
rhase Feb 16, 2021
eb94970
set GOOGLE_APPLICATION_CREDENTIALS only for digdag-standards
rhase Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bugfix
  • Loading branch information
@rhase
rhase committed May 27, 2021
commit 814cbc5b465856ec06c31d764d8b1c809b5ac4b7
2 changes: 1 addition & 1 deletion digdag-standards/src/main/java/io/digdag/standards/operator/gcp/GcpCredentialProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ GcpCredential credential(SecretProvider secrets)
builder.projectId(ServiceOptions.getDefaultProjectId())
.credential(GoogleCredential.getApplicationDefault());
}
catch (IOException e) {
catch (Exception e) {
throw new TaskExecutionException(
"Could not get google cloud credential: need gcp.credential secret or Application Default Credentials",
e
Expand Down