-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prod and prod_dim tensor ops #1460
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
- Coverage 85.88% 85.70% -0.19%
==========================================
Files 645 645
Lines 71749 71953 +204
==========================================
+ Hits 61625 61666 +41
- Misses 10124 10287 +163 ☔ View full report in Codecov by Sentry. |
crates/burn-jit/src/element.rs
Outdated
@@ -22,7 +23,7 @@ where | |||
} | |||
|
|||
/// The float element type for the jit backend. | |||
pub trait FloatElement: JitElement + Element {} | |||
pub trait FloatElement: JitElement + Element + Float {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea, since we may have u8
implement the FloatElement with quantization. Is there a reason to add this trait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me review it again. It might have been a left over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it. It was a left over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only had a question but that was already addressed by the previous review + modifications.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
prod
andprod_axis
tensor operators #526prod
andprod_dim
for Candle backend #1454prod
andprod_dim
for WGPU backend #1461Changes
Testing