-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor - JIT] Gather Scatter new implementations #1356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 comments, but I'm not sure about them. The rest is fine!
}, | ||
Instruction::Index { lhs, rhs, out } => { | ||
let item = out.item(); | ||
f.write_fmt(format_args!("{out} = {item}({lhs}[{rhs}]);\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but shouldn't item
be elem
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No not here
|
||
gpu!(scope, if(should_skip).then(|_| { | ||
// Nothing to do. | ||
}).else(|scope| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the DSL but is it necessary to have
if x nothing else stuff
instead of if !x stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not is not yet supported, should be updated when is
Refactor gather scatter to use the new GPU agnostic internal represetation.