Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richacl #109

Closed
wants to merge 27 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d5d1fb4
vfs: Indicate that the permission functions take all the MAY_* flags
Oct 18, 2011
0f69c40
vfs: Add hex format for MAY_* flag values
kvaneesh Oct 18, 2011
bf56180
vfs: Pass all mask flags down to iop->check_acl
Oct 18, 2011
518cbba
vfs: Add a comment to inode_permission()
Oct 18, 2011
89e1033
vfs: Add generic IS_ACL() test for acl support
Oct 18, 2011
45481f1
vfs: Add IS_RICHACL() test for richacl support
Oct 18, 2011
c684918
vfs: Optimize out IS_RICHACL() if CONFIG_FS_RICHACL is not defined
Oct 18, 2011
004723e
vfs: Add new file and directory create permission flags
Oct 18, 2011
1654a09
vfs: Add delete child and delete self permission flags
Oct 18, 2011
3437a82
vfs: Make the inode passed to inode_change_ok non-const
Oct 18, 2011
e963a4c
vfs: Add permission flags for setting file attributes
Oct 18, 2011
26dc449
vfs: Make acl_permission_check() work for richacls
Oct 18, 2011
e210ab8
richacl: In-memory representation and helper functions
Oct 18, 2011
36ee026
richacl: Permission mapping functions
Oct 18, 2011
dc240c0
richacl: Compute maximum file masks from an acl
Oct 18, 2011
6be646b
richacl: Update the file masks in chmod()
Oct 18, 2011
61bf134
richacl: Permission check algorithm
Oct 18, 2011
9d9bef3
richacl: Create-time inheritance
Oct 18, 2011
8013f16
richacl: Check if an acl is equivalent to a file mode
Oct 18, 2011
5882a81
richacl: Automatic Inheritance
Oct 18, 2011
862d861
richacl: xattr mapping functions
Oct 18, 2011
69d9df5
vfs: Cache richacl in struct inode
Oct 18, 2011
e86e410
vfs: Add richacl permission check
kvaneesh Oct 18, 2011
434e398
ext4: Use IS_POSIXACL() to check for POSIX ACL support
kvaneesh Oct 18, 2011
69b47fd
ext4: Implement rich acl for ext4
kvaneesh Oct 18, 2011
e17ad31
ext4: Add Ext4 compat richacl feature flag
kvaneesh Oct 18, 2011
13fc237
ext4: Add temporary richacl mount option for ext4
kvaneesh Oct 18, 2011
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
richacl: Permission check algorithm
As in the standard POSIX file permission model, each process is the
owner, group, or other file class.  A process is

  - in the owner file class if it owns the file,
  - in the group file class if it is in the file's owning group or it
    matches any of the user or group entries, and
  - in the other file class otherwise.

Each file class is associated with a file mask.

A richacl grants a requested access if the NFSv4 acl in the richacl
grants the requested permissions (according to the NFSv4 permission
check algorithm) and the file mask that applies to the process includes
the requested permissions.

Acked-by: J. Bruce Fields <[email protected]>
Acked-by: David Howells <[email protected]>
Signed-off-by: Andreas Gruenbacher <[email protected]>
Signed-off-by: Aneesh Kumar K.V <[email protected]>
  • Loading branch information
Andreas Gruenbacher authored and kvaneesh committed Oct 23, 2011
commit 61bf1349bb04d434f849c516034ca65650ddd1ac
99 changes: 99 additions & 0 deletions fs/richacl_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,3 +352,102 @@ richacl_chmod(struct richacl *acl, mode_t mode)
return clone;
}
EXPORT_SYMBOL_GPL(richacl_chmod);

/**
* richacl_permission - richacl permission check algorithm
* @inode: inode to check
* @acl: rich acl of the inode
* @mask: requested access (ACE4_* bitmask)
*
* Checks if the current process is granted @mask flags in @acl.
*/
int
richacl_permission(struct inode *inode, const struct richacl *acl,
unsigned int mask)
{
const struct richace *ace;
unsigned int requested = mask, denied = 0;
int in_owning_group = in_group_p(inode->i_gid);
int in_owner_or_group_class = in_owning_group;

/*
* We don't need to know which class the process is in when the acl is
* not masked.
*/
if (!(acl->a_flags & ACL4_MASKED))
in_owner_or_group_class = 1;

/*
* A process is
* - in the owner file class if it owns the file,
* - in the group file class if it is in the file's owning group or
* it matches any of the user or group entries, and
* - in the other file class otherwise.
*/

/*
* Check if the acl grants the requested access and determine which
* file class the process is in.
*/
richacl_for_each_entry(ace, acl) {
unsigned int ace_mask = ace->e_mask;

if (richace_is_inherit_only(ace))
continue;
if (richace_is_owner(ace)) {
if (current_fsuid() != inode->i_uid)
continue;
goto is_owner;
} else if (richace_is_group(ace)) {
if (!in_owning_group)
continue;
} else if (richace_is_unix_id(ace)) {
if (ace->e_flags & ACE4_IDENTIFIER_GROUP) {
if (!in_group_p(ace->e_id))
continue;
} else {
if (current_fsuid() != ace->e_id)
continue;
}
} else
goto is_everyone;

is_owner:
/* The process is in the owner or group file class. */
in_owner_or_group_class = 1;

is_everyone:
/* Check which mask flags the ACE allows or denies. */
if (richace_is_deny(ace))
denied |= ace_mask & mask;
mask &= ~ace_mask;

/*
* Keep going until we know which file class
* the process is in.
*/
if (!mask && in_owner_or_group_class)
break;
}
denied |= mask;

if (acl->a_flags & ACL4_MASKED) {
unsigned int file_mask;

/*
* The file class a process is in determines which file mask
* applies. Check if that file mask also grants the requested
* access.
*/
if (current_fsuid() == inode->i_uid)
file_mask = acl->a_owner_mask;
else if (in_owner_or_group_class)
file_mask = acl->a_group_mask;
else
file_mask = acl->a_other_mask;
denied |= requested & ~file_mask;
}

return denied ? -EACCES : 0;
}
EXPORT_SYMBOL_GPL(richacl_permission);
2 changes: 2 additions & 0 deletions include/linux/richacl.h
Original file line number Diff line number Diff line change
Expand Up @@ -282,5 +282,7 @@ extern unsigned int richacl_mode_to_mask(mode_t);
extern unsigned int richacl_want_to_mask(unsigned int);
extern void richacl_compute_max_masks(struct richacl *);
extern struct richacl *richacl_chmod(struct richacl *, mode_t);
extern int richacl_permission(struct inode *, const struct richacl *,
unsigned int);

#endif /* __RICHACL_H */