Skip to content

Commit

Permalink
Revert "printk: add kthread console printers"
Browse files Browse the repository at this point in the history
This reverts commit 09c5ba0.

This reverts commit b87f023.

The testing of 5.19 release candidates revealed missing synchronization
between early and regular console functionality.

It would be possible to start the console kthreads later as a workaround.
But it is clear that console lock serialized console drivers between
each other. It opens a big area of possible problems that were not
considered by people involved in the development and review.

printk() is crucial for debugging kernel issues and console output is
very important part of it. The number of consoles is huge and a proper
review would take some time. As a result it need to be reverted for 5.19.

Link: https://lore.kernel.org/r/YrBdjVwBOVgLfHyb@alley
Signed-off-by: Petr Mladek <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
pmladek committed Jun 23, 2022
1 parent 2d9ef94 commit 5831788
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 309 deletions.
2 changes: 0 additions & 2 deletions include/linux/console.h
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ struct console {
uint ospeed;
u64 seq;
unsigned long dropped;
struct task_struct *thread;

void *data;
struct console *next;
};
Expand Down
Loading

0 comments on commit 5831788

Please sign in to comment.