Skip to content

Commit

Permalink
isci: fix apc mode definition
Browse files Browse the repository at this point in the history
The original apc mode definition is the correct one, the fix from commit
4711ba1 "isci: fix oem parameter initialization and mode detection" was based
on a typo from a specification update.

Signed-off-by: Dan Williams <[email protected]>
  • Loading branch information
djbw committed Jul 3, 2011
1 parent b5f18a2 commit 4eefd25
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions drivers/scsi/isci/probe_roms.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ struct isci_oem_hdr {
#define ISCI_ROM_SIG "ISCUOEMB"
#define ISCI_ROM_SIG_SIZE 8

#define ISCI_PREBOOT_SOURCE_INIT (0x00)
#define ISCI_PREBOOT_SOURCE_OROM (0x80)
#define ISCI_PREBOOT_SOURCE_EFI (0x81)

#define ISCI_EFI_VENDOR_GUID \
EFI_GUID(0x193dfefa, 0xa445, 0x4302, 0x99, 0xd8, 0xef, 0x3a, 0xad, \
0x1a, 0x04, 0xc6)
Expand All @@ -116,8 +112,8 @@ struct isci_oem_hdr {
* being assigned is sufficient to declare manual PORT configuration.
*/
enum SCIC_PORT_CONFIGURATION_MODE {
SCIC_PORT_AUTOMATIC_CONFIGURATION_MODE = 0,
SCIC_PORT_MANUAL_CONFIGURATION_MODE = 1
SCIC_PORT_MANUAL_CONFIGURATION_MODE = 0,
SCIC_PORT_AUTOMATIC_CONFIGURATION_MODE = 1
};

struct sci_bios_oem_param_block_hdr {
Expand Down
4 changes: 2 additions & 2 deletions firmware/isci/isci_firmware.bin.ihex
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
:10000000495343554F454D42E70017100002000089
:10001000000000000000000001000000000000FFE0
:10001000000000000000000101000000000000FFDF
:10002000FFCF5F01000000037C0E00037C0E000385
:100030007C0E00037C0E00FFFFCF5F010000000379
:100040007C0E00037C0E00037C0E00037C0E00FF80
:10005000FFCF5F01000000037C0E00037C0E000355
:100060007C0E00037C0E00FFFFCF5F010000000349
:100070007C0E00037C0E00037C0E00037C0E00004F
:100070007C0E00037C0E00037C0E00037C0E00014E
:1000800001000000000000FFFFCF5F02000000033E
:100090007C0E00037C0E00037C0E00037C0E00FF30
:1000A000FFCF5F02000000037C0E00037C0E000304
Expand Down

0 comments on commit 4eefd25

Please sign in to comment.