Skip to content

Commit

Permalink
mm/hugetlb: have CONFIG_HUGETLB_PAGE select CONFIG_XARRAY_MULTI
Browse files Browse the repository at this point in the history 
After commit a08c719 "mm/filemap: remove hugetlb special casing in
filemap.c", hugetlb pages are stored in the page cache in base page sized
indexes.  This leads to multi index stores in the xarray which is only
supporting through CONFIG_XARRAY_MULTI.  The other page cache user of
multi index stores ,THP, selects XARRAY_MULTI.  Have CONFIG_HUGETLB_PAGE
follow this behavior as well to avoid the BUG() with a CONFIG_HUGETLB_PAGE
&& !CONFIG_XARRAY_MULTI config.

Link: https://lkml.kernel.org/r/[email protected]
Fixes: a08c719 ("mm/filemap: remove hugetlb special casing in filemap.c")
Signed-off-by: Sidhartha Kumar <[email protected]>
Reported-by: Al Viro <[email protected]>
Cc: Mike Kravetz <[email protected]>
Cc: Muchun Song <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
@sidkumar99 @akpm00
sidkumar99 authored and akpm00 committed Dec 7, 2023
1 parent 801a2b1 commit 4a3ef6b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/Kconfig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ config HUGETLBFS

config HUGETLB_PAGE
def_bool HUGETLBFS
select XARRAY_MULTI

config HUGETLB_PAGE_OPTIMIZE_VMEMMAP
def_bool HUGETLB_PAGE
Expand Down

0 comments on commit 4a3ef6b

Please sign in to comment.