Skip to content

Commit

Permalink
pmdomain: raspberrypi-power: Adjust packet definition
Browse files Browse the repository at this point in the history
According to the official Mailbox property interface the second part
of RPI_FIRMWARE_SET_POWER_STATE ( and so on ...) is named state because
it represent u32 flags and just the lowest bit is for on/off. So rename it
to align with documentation and prepare the driver for further changes.

Link: https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface
Signed-off-by: Stefan Wahren <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Ulf Hansson <[email protected]>
  • Loading branch information
lategoodbye authored and storulf committed Aug 14, 2024
1 parent 8287e9e commit 49d2a1e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/pmdomain/bcm/raspberrypi-power.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ struct rpi_power_domains {
*/
struct rpi_power_domain_packet {
u32 domain;
u32 on;
u32 state;
};

/*
Expand All @@ -53,7 +53,7 @@ static int rpi_firmware_set_power(struct rpi_power_domain *rpi_domain, bool on)
struct rpi_power_domain_packet packet;

packet.domain = rpi_domain->domain;
packet.on = on;
packet.state = on;
return rpi_firmware_property(rpi_domain->fw,
rpi_domain->old_interface ?
RPI_FIRMWARE_SET_POWER_STATE :
Expand Down Expand Up @@ -142,13 +142,13 @@ rpi_has_new_domain_support(struct rpi_power_domains *rpi_domains)
int ret;

packet.domain = RPI_POWER_DOMAIN_ARM;
packet.on = ~0;
packet.state = ~0;

ret = rpi_firmware_property(rpi_domains->fw,
RPI_FIRMWARE_GET_DOMAIN_STATE,
&packet, sizeof(packet));

return ret == 0 && packet.on != ~0;
return ret == 0 && packet.state != ~0;
}

static int rpi_power_probe(struct platform_device *pdev)
Expand Down

0 comments on commit 49d2a1e

Please sign in to comment.