Skip to content

Commit

Permalink
mtd: maps: Fix refcount leak in of_flash_probe_versatile
Browse files Browse the repository at this point in the history
of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: b0afd44 ("mtd: physmap_of: add a hook for Versatile write protection")
Signed-off-by: Miaoqian Lin <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
Link: https://lore.kernel.org/linux-mtd/[email protected]
  • Loading branch information
Yuuoniy authored and miquelraynal committed Jun 6, 2022
1 parent f2906aa commit 33ec82a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/mtd/maps/physmap-versatile.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ int of_flash_probe_versatile(struct platform_device *pdev,

versatile_flashprot = (enum versatile_flashprot)devid->data;
rmap = syscon_node_to_regmap(sysnp);
of_node_put(sysnp);
if (IS_ERR(rmap))
return PTR_ERR(rmap);

Expand Down

0 comments on commit 33ec82a

Please sign in to comment.