Skip to content

Commit

Permalink
rcu: Make RCU_FANOUT_LEAF help text more explicit about skew_tick
Browse files Browse the repository at this point in the history
If you set RCU_FANOUT_LEAF too high, you can get lock contention
on the leaf rcu_node, and you should boot with the skew_tick kernel
parameter set in order to avoid this lock contention.  This commit
therefore upgrades the RCU_FANOUT_LEAF help text to explicitly state
this.

Signed-off-by: Paul E. McKenney <[email protected]>
  • Loading branch information
paulmck committed Apr 19, 2017
1 parent 468d01b commit 0248288
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions init/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -612,11 +612,17 @@ config RCU_FANOUT_LEAF
initialization. These systems tend to run CPU-bound, and thus
are not helped by synchronized interrupts, and thus tend to
skew them, which reduces lock contention enough that large
leaf-level fanouts work well.
leaf-level fanouts work well. That said, setting leaf-level
fanout to a large number will likely cause problematic
lock contention on the leaf-level rcu_node structures unless
you boot with the skew_tick kernel parameter.

Select a specific number if testing RCU itself.

Select the maximum permissible value for large systems.
Select the maximum permissible value for large systems, but
please understand that you may also need to set the skew_tick
kernel boot parameter to avoid contention on the rcu_node
structure's locks.

Take the default if unsure.

Expand Down

0 comments on commit 0248288

Please sign in to comment.