add needed jvm opts to run cassandra tests under java11+; see #598 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennetelli
reviewed
Feb 14, 2022
| @@ -51,6 +51,8 @@ | |||
| <artifactId>curator-test</artifactId> | |||
| <version>5.2.0</version> | |||
| </dependency> | |||
| <!-- brauchen wir hier hier nur die api? nur -simple? nur logback? nur provided? --> | |||
| <!-- https://repo1.maven.org/maven2/org/slf4j/ --> | |||
There was a problem hiding this comment.
good question. I don't know. You can give it a try if you want :)
There was a problem hiding this comment.
Whoops, these logging changes were not planned to be in this PR as well ;)
Sorry for that, I guess I have to dig into this as my next todo then :)
bennetelli
approved these changes
Feb 14, 2022
|
Many thanks for your PR :) I always wanted to upgrade the cassandra dependencies to achieve this. Good that's also possible without upgrading. Nice work!:) |
|
Works with java 8 and 11 on my machine. |
|
@hennr now I (or we :-) ) need to replace the jdk internal nashorn engine to be able to build jdk 13+ |
Yeah, well. Let's see 😏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bennetelli , togglz does build properly with this on my machine.
If you'd change fail-fast: true to false I think you should see the java 8 and 11 builds pass in a matrix build.