-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cipher): mpz upgrade #501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍, only one thing
sinui0
force-pushed
the
refactor/mpz-upgrade-prf
branch
from
June 12, 2024 19:53
4bd10e7
to
006c70a
Compare
sinui0
force-pushed
the
refactor/mpz-upgrade-cipher
branch
from
June 12, 2024 19:56
1fb3b7e
to
d9f3bf1
Compare
th4s
approved these changes
Jun 13, 2024
themighty1
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* refactor(cipher): mpz upgrade * add debug impl * bug fix * update expect messages
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* refactor(cipher): mpz upgrade * add debug impl * bug fix * update expect messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our
block-cipher
andstream-cipher
crates to use the newmpz
API.Note: The exact commit of
mpz
is not settled yet, we will update this prior to release.Changes