Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cipher): mpz upgrade #501

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Jun 12, 2024

This PR updates our block-cipher and stream-cipher crates to use the new mpz API.

Note: The exact commit of mpz is not settled yet, we will update this prior to release.

Changes

  • A bit of general clean up including making the error types opaque
  • Adds preprocessing to the block cipher

@sinui0 sinui0 requested review from themighty1 and th4s June 12, 2024 05:32
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍, only one thing

components/cipher/block-cipher/src/cipher.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 force-pushed the refactor/mpz-upgrade-cipher branch from 1fb3b7e to d9f3bf1 Compare June 12, 2024 19:56
@sinui0 sinui0 changed the base branch from refactor/mpz-upgrade-prf to mpz-upgrade June 12, 2024 19:56
@sinui0 sinui0 requested a review from th4s June 12, 2024 20:01
Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

components/cipher/block-cipher/src/cipher.rs Outdated Show resolved Hide resolved
@sinui0 sinui0 merged commit 77b9450 into mpz-upgrade Jun 13, 2024
@sinui0 sinui0 deleted the refactor/mpz-upgrade-cipher branch June 13, 2024 18:49
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(cipher): mpz upgrade

* add debug impl

* bug fix

* update expect messages
sinui0 added a commit that referenced this pull request Jun 25, 2024
* refactor(cipher): mpz upgrade

* add debug impl

* bug fix

* update expect messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants