Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tlsn-examples): update hyper and use http prover #434

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Feb 9, 2024

This PR updates/simplifies the examples. It depends on both #433 and #432, otherwise the twitter example will fail.

Changes

  1. Bump version of hyper to 1.1 and update code to accommodate
  2. Factor out some common code into the tlsn-examples lib
  3. Update the twitter DM example to use HttpProver and new selective disclosure API.
  4. Update twitter DM to use deferred decryption feature.

Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. The examples look a lot better ❤️

However, the Twitter examples fails for me now

tlsn/examples/twitter/twitter_dm.rs Show resolved Hide resolved
@sinui0
Copy link
Member Author

sinui0 commented Feb 12, 2024

Rebased to include changes from #432 . @heeckhau merging is blocked on your review, please retry and confirm 🙏

@heeckhau
Copy link
Member

heeckhau commented Feb 12, 2024

Rebased to include changes from #432 . @heeckhau merging is blocked on your review, please retry and confirm 🙏

@sinui0 I now get:

2024-02-12T23:03:53.833498Z DEBUG finalize: yamux::connection: 06e555ee: new outbound (Stream 06e555ee/63) of (Connection 06e555ee Client (streams 31))    
2024-02-12T23:03:54.614104Z DEBUG twitter_dm: Notarization complete!
thread 'main' panicked at examples/twitter/twitter_dm.rs:177:10:
called `Result::unwrap()` on an `Err` value: MissingCommitment

@sinui0
Copy link
Member Author

sinui0 commented Feb 12, 2024

Rebased to include changes from #432 . @heeckhau merging is blocked on your review, please retry and confirm 🙏

@sinui0 I now get:

2024-02-12T23:03:53.833498Z DEBUG finalize: yamux::connection: 06e555ee: new outbound (Stream 06e555ee/63) of (Connection 06e555ee Client (streams 31))    
2024-02-12T23:03:54.614104Z DEBUG twitter_dm: Notarization complete!
thread 'main' panicked at examples/twitter/twitter_dm.rs:177:10:
called `Result::unwrap()` on an `Err` value: MissingCommitment

This is fixed by #433 😅

Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved

@sinui0 sinui0 merged commit 0d269ed into dev Feb 13, 2024
15 checks passed
@sinui0 sinui0 deleted the http-example branch February 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants