fix: sort merkle indices #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinui0
force-pushed
the
fix/sort-merkle-indices
branch
from
158cd20
to
d101fba
Compare
sinui0
force-pushed
the
fix/sort-merkle-indices
branch
from
d101fba
to
55032b1
Compare
themighty1
reviewed
Sep 22, 2023
| /// | ||
| /// # Panics | ||
| /// | ||
| /// - if `indices` is not sorted. |
There was a problem hiding this comment.
@sinui0 , instead of imposing the burden on the caller to sort the indices, we can just sort them right in this fn.
|
|
||
| // fail because of the extra leaf which was not covered by the proof |
There was a problem hiding this comment.
@sinui0 , I'm not finding this test among the new tests.
|
@themighty1 this was merged in expediently because it was going to get in the way of the hackathon. Do you mind opening an issue when you catch something after a PR is closed? |
|
@sinui0 , I wasn't sure if this was the intended behaviour, so I thought I'd ask. Ok, i'll open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
tlsn-corerelated to the merkle tree module expecting the leaf indices to be sorted, but they're not. Now they are.