Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/* : add Tamil translation #9086

Merged
merged 32 commits into from
Oct 17, 2022
Merged

Conversation

ndrohith09
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant

This comment was marked as outdated.

@github-actions github-actions bot added the translation Translate pages from one language to another. label Oct 15, 2022
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@kbdharun kbdharun added the mass changes Changes that affect multiple pages. label Oct 16, 2022
@kbdharun kbdharun self-assigned this Oct 16, 2022
@kbdharun
Copy link
Member

kbdharun commented Oct 16, 2022

Thanks for this massive PR, Welcome to tldr. I will review it later today.

இந்த பெரிய PRக்கு நன்றி, tldrக்கு வரவேற்கிறோம். நான் இதை இன்று பின்னர் மதிப்பாய்வு செய்கிறேன்.

Edit. I will my review in English for others to refer to.

@ndrohith09
Copy link
Contributor Author

Thank you @kbdharun

pages.ta/windows/assoc.md Outdated Show resolved Hide resolved
pages.ta/windows/attrib.md Outdated Show resolved Hide resolved
pages.ta/windows/attrib.md Outdated Show resolved Hide resolved
pages.ta/windows/attrib.md Outdated Show resolved Hide resolved
pages.ta/windows/attrib.md Outdated Show resolved Hide resolved
pages.ta/windows/choco-search.md Outdated Show resolved Hide resolved
pages.ta/windows/choco-search.md Outdated Show resolved Hide resolved
pages.ta/windows/choco-search.md Outdated Show resolved Hide resolved
pages.ta/windows/choco-search.md Outdated Show resolved Hide resolved
pages.ta/windows/choco-search.md Outdated Show resolved Hide resolved
@kbdharun
Copy link
Member

kbdharun commented Oct 16, 2022

Thank you so much for this PR @ndrohith09. Keep up the good work. It's not every day that I get to review Tamil translations.

Usually I would request changes from translators or PR authors. But since I am a native speaker, I took up the work and proofread this PR and applied our usual suggestions.

Sorry if I overwhelmed you with 157 review comments 😆.

Please batch all my suggestions in the Files changed tab and make a single commit in this PR.

I will make some suggestions that will be useful for you in future,

  • Refer to common-arguments in future for paths.
  • Translate command arguments inside {{}} in future as it will be easy for native speakers to understand the placeholders/arguments.
  • Try to make a distinct difference between a command name and description using `` whenever necessary.
  • For terms like API, etc don't translate them to Tamil. Except in some cases in placeholders/command arguments.

I guess I covered it all.

You might ask me, why we use certain words or follow certain methods in some cases.

The answer is that

  • For words like packages தொகுப்பு is correct but we prefer நிரல்தொகுப்பு (program package) as it provides a distinction to the native speaker between a package used in computer (software) and our physical parcels/packages.
  • For "More information:" links we use மேலும் விவரத்திற்கு: instead of மேலும் தகவல்: even though it is also right because it works better with all our pages. This has been discussed in the past and we use this term after reaching a consensus. You can refer to this here.
  • Paths is the only place where we struggle, if you noticed my suggestions we used அடைவிற்குப்/பாதை in most places for path/to/directory, it is grammatically correct but it can't be applied in all pages (paths, when translated, might confuse the readers) and for path/to/file, I suggested பாதை/டு/கோப்பு instead of கோப்பின்/பாதை because the later which is grammatically correct can't be used in all places. So we are using டு which is a direct transliteration of the English word to. [Based on different use cases we used a different format of paths before, now we use the generic ones that are present in common-arguments as those fit well with all tenses].
  • For alias pages, we generally use the one present in this file, but it isn't standardised except the first line, so we can change the alias pages content or format to our flexibility based on usage.

Seems like I wrote an essay. 😅
Time for the big news 🎉 , I am working on a separate style guide for Tamil I will probably add it by this Diwali time.

Once again, Thanks.
Regards,
Dharun Krishna

Request to maintainers: When merging this PR keep the Co-authored by section. I worked hard on this PR testing out commands and proofreading translations for the past 3 hours.

@ndrohith09
Copy link
Contributor Author

Not a problem @kbdharun . I learnt a lot . Will make the necessary changes and will commit .

@ndrohith09
Copy link
Contributor Author

@kbdharun I have made all the changes which was specified by you .. Thanks a lot for helping me . I learnt many things from this one PR . Wishing to learn a lot from you .

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My final 3 suggestions with this applied the PR is good to go.

pages.ta/windows/azcopy.md Outdated Show resolved Hide resolved
pages.ta/windows/comp.md Outdated Show resolved Hide resolved
pages.ta/windows/comp.md Outdated Show resolved Hide resolved
@ndrohith09
Copy link
Contributor Author

@kbdharun The concerned changes were done.

@navarroaxel navarroaxel changed the title windows/* : add Tamil translations windows/* : add Tamil translation Oct 17, 2022
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 853a466 into tldr-pages:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants