Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OS X and Linux pages into pages/common #51

Merged
merged 1 commit into from
Jan 29, 2014
Merged

Move OS X and Linux pages into pages/common #51

merged 1 commit into from
Jan 29, 2014

Conversation

zlatanvasovic
Copy link
Contributor

Moves common commands into pages/common.

@rprieto
Copy link
Contributor

rprieto commented Jan 29, 2014

Thanks! Just to confirm, this moves every command into common. Are all the example fine on Linux for the moment?

@zlatanvasovic
Copy link
Contributor Author

Yes, I tested examples.

If anyone finds a bug with this, it can be easily fixed. ;)

2014-01-29 Romain Prieto [email protected]

Thanks! Just to confirm, this moves every command into common. Are all
the example fine on Linux for the moment?


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-33637154
.

Zlatan Vasović - ZDroid

@rprieto
Copy link
Contributor

rprieto commented Jan 29, 2014

That's great news, nice work!

rprieto added a commit that referenced this pull request Jan 29, 2014
Move OS X and Linux pages into pages/common
@rprieto rprieto merged commit 1775275 into tldr-pages:master Jan 29, 2014
@zlatanvasovic zlatanvasovic deleted the common branch January 29, 2014 22:50
@twe4ked
Copy link

twe4ked commented Jan 30, 2014

I can't seem to find any pages. I've only just installed the app now though so I've never seen it work but I'm assuming it's something to do with this change.

$ tldr curl
ERROR: curl command not available

@rprieto
Copy link
Contributor

rprieto commented Jan 30, 2014

Sorry, the new published version (0.0.5) should work if you npm install -g tldr again.

Unfortunately you're right, the move to common was not backwards compatible. I think we should move towards packaged bundles created at build time (like tldr-pages.tar.gz), so that new pages can be released separately from the PR lifecycle. It would also eventually allow for ways to determine compatibility between the tldr binary and a given bundle version.

@twe4ked
Copy link

twe4ked commented Jan 30, 2014

@rprieto Thanks! I thought it would be something like that. I must have installed just before this was released.

@zlatanvasovic
Copy link
Contributor Author

No. Moving of this is backwars compatible, because this doesn't change
usage. Semver says that if you don't change usage you can change the code
as you want.

2014-01-30 Odin Dutton [email protected]:

@rprieto https://github.com/rprieto Thanks! I thought it would be
something like that. I must have installed just before this was released.


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-33651868
.

Zlatan Vasović - ZDroid

@rprieto
Copy link
Contributor

rprieto commented Jan 30, 2014

I guess in that sense it is, but people who don't upgrade won't get any pages - since 0.0.4 only reads from pages/osx.

@zlatanvasovic
Copy link
Contributor Author

Hm. So they should update the version? Updating project versions is
perfectly normal if something changes.

2014-01-30 Romain Prieto [email protected]:

I guess in that sense it is, but people who don't upgrade won't get any
pages - since 0.0.4 only reads from pages/osx.


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-33684674
.

Zlatan Vasović - ZDroid

@rprieto
Copy link
Contributor

rprieto commented Jan 30, 2014

That's it. And for now given the project is young I think it's OK we're still experimenting.

In the future though it's be nice to have ways to control this better, because it could take people a while to realise why tldr cp says "no such command" all of a sudden. That shouldn't be their concern.

@zlatanvasovic
Copy link
Contributor Author

Ok. This is just 0.0.5 and Semver says that your project is stable when it
reach 1.0.0, so don't worry. :)

You can note that in the readme, it may help! :)

2014-01-30 Romain Prieto [email protected]:

That's it. And for now given the project is young I think it's OK we're
still experimenting.

In the future though it's be nice to have ways to control this better,
because it could take people a while to realise why tldr cp says "no such
command" all of a sudden. That shouldn't be their concern.


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-33684913
.

Zlatan Vasović - ZDroid

@rprieto
Copy link
Contributor

rprieto commented Jan 30, 2014

Good idea, I'll amend it tomorrow! :)

@zlatanvasovic
Copy link
Contributor Author

:)

2014-01-30 Romain Prieto [email protected]:

Good idea, I'll amend it tomorrow! :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/51#issuecomment-33685401
.

Zlatan Vasović - ZDroid

@waldyrious waldyrious added architecture Organization of the pages per language, platform, etc. decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. labels Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Organization of the pages per language, platform, etc. decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants