-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpicam-{hello,jpeg,raw,still,vid}: add page #12078
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I have added some comments. However, we usually put pages for different commands into different files. I think that it would be better if you created one file for rpicam-hello, one for rpicam-jpeg and so on :)
Ok sorry. First PR I was expecting there to be some problems :) (I probably won't get to this tonight though it definitely will be completed by tomorrow) |
Co-authored-by: Juri Dispan <[email protected]>
Co-authored-by: Juri Dispan <[email protected]>
Co-authored-by: Juri Dispan <[email protected]>
Co-authored-by: Juri Dispan <[email protected]>
Co-authored-by: Juri Dispan <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I have suggested some changes:
- If the value is already provided in the description, please don't use a placeholder, but rather leave it as part of the command. From the contributing guide:
However, if the description suggests a specific value, leave it as part of the command, and not as a placeholder, for example:
- Display records more recent than 3 days: `lastlog --time 3`
- Fix the path placeholder syntax. See the style guide:
Paths
- Use
{{filename}}
when just the file name is expected.- For any reference to paths of files or directories,
use the format{{path/to/<placeholder>}}
,
except when the location is implicit.- When the path cannot be relative,
but has to start at the root of the filesystem,
prefix it with a slash,
such asget {{/path/to/remote_file}}
.- In case of a possible reference both to a file or a directory,
use{{path/to/file_or_directory}}
.
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating my feedback!
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
Co-authored-by: Vitor Henrique <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied your changes except for one which I had to resolve...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
pages/linux/rpicam-still.md
Outdated
|
||
- Capture a 100 second exposure image: | ||
|
||
`rpicam-still -o name/of/file.jpg --shutter {{100000000}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`rpicam-still -o name/of/file.jpg --shutter {{100000000}}` | |
`rpicam-still -o name/of/file.jpg --shutter {{100000}}` |
As far as I know, 100 seconds is 100000 milliseconds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to tldr and thanks for your contribution.
LGTM, after @sebastiaanspeck's suggestions.
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
I probably need to go back to second grade math...
Co-authored-by: Sebastiaan Speck <[email protected]>
common
,linux
,osx
,windows
,sunos
,android
, etc.The version of the command being documented is the latest version.