New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly marshal UTF-8 paths for AssemblyName #376

Merged

tjanczuk merged 1 commit into tjanczuk:master from anaisbetts:utf8-assembly-path

Aug 23, 2016

Contributor

anaisbetts commented Jan 6, 2016

To Repro:

Create a DLL you want to load under a non-ASCII path (we ran into this with a Russian username)
Try to load it via assemblyName
Kablooey, we try to load a ASCII-mangled path

Atom nuked trailing whitespace, sorry about that - https://github.com/tjanczuk/edge/pull/376/files?w=1 for a more readable diff


          Correctly marshal UTF-8 paths

50592fc

Owner

tjanczuk commented Aug 23, 2016

Thanks!

tjanczuk merged commit 8175176 into tjanczuk:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet