Install script updates and compile fixes for Linux system without Mono #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we build Edge.js on a Linux or OS X system without Mono installed, we don't generate edge_nativeclr.node at all and when we load Edge at runtime, we then default to trying to load edge_coreclr.node. This removes the need to specify the EDGE_USE_CORECLR environment variable when using Edge on a Linux/OS X system without Mono.
tjanczuk
added a commit
that referenced
this pull request
Dec 22, 2015
Install script updates and compile fixes for Linux system without Mono
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
edge_nativeclr.node. Whenedge_nativeclr.nodeis not available, we also fall back to trying to useedge_coreclr.node. This removes the requirement that theEDGE_USE_CORECLR=1environment variable be set even if no alternative runtime is available.