#44 save merged buffer as dng #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotherofken
commented
Feb 12, 2020
| Halide::Runtime::Buffer<uint16_t> raw_buffer(image_data, raw_width, raw_height); | ||
| buffer.copy_from(raw_buffer.translated({-left, -top})); | ||
| } | ||
|
|
||
| void RawImage::WriteDng(const std::string &output_path, const Halide::Runtime::Buffer<uint16_t> &buffer) const |
There was a problem hiding this comment.
New method to write DNG.
brotherofken
commented
Feb 12, 2020
| @@ -0,0 +1,74 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
The class that does conversion from LibRaw to DNG.
|
Colors are correct at least for Canon RAWs. |
|
Is it ready to be merged? |
|
No, it's not finished yet. |
brotherofken
commented
Feb 15, 2020
| @@ -7,39 +7,28 @@ | |||
| #include <Halide.h> | |||
| #include "finish.h" | |||
|
|
|||
| class AbstractInputSource { | |||
There was a problem hiding this comment.
I decided to simplify IO because there is only one type of input - RAW files, thus this abstraction is redundant.
brotherofken
commented
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44