Implement ElixirSense. #67

potterdai · 2017-06-03T14:21:53Z

-Implement ElixirSense.
-Add SignatureHelpProvider.
-Upgrade VSCode and Typescript version.

timmhirsens · 2017-06-04T09:28:35Z

Woah, awesome! Gonna check this PR later today. Thank you very much!

timmhirsens

Looks good to me, despite a few minor issues.
Do you mind fixing those? Otherwise I would do that myself after merging.

timmhirsens · 2017-06-05T09:14:11Z

.vscode/launch.json

@@ -21,7 +21,7 @@
 			"args": ["--extensionDevelopmentPath=${workspaceRoot}", "--extensionTestsPath=${workspaceRoot}/out/test" ],
 			"stopOnEntry": false,
 			"sourceMaps": true,
-			"outFiles": ["out/test"],
+            "outFiles": [ "${workspaceRoot}/out/test/**/*.js" ],
 			"preLaunchTask": "npm"
 		}


timmhirsens · 2017-06-05T09:14:25Z

.vscode/settings.json

@@ -5,6 +5,5 @@
 	},
 	"search.exclude": {
 		"out": true // set this to false to include "out" folder in search results
-	},
-	"typescript.tsdk": "./node_modules/typescript/lib" // we want to use the TS server from our node_modules folder to control its version
+	}
 }


Any reason for this change?

Hey, this is overwritten by autogenerated file from latest yeoman.
I just added it back. = )

timmhirsens · 2017-06-05T09:14:36Z

.vscode/tasks.json

@@ -23,7 +23,7 @@
 	"args": ["run", "compile", "--loglevel", "silent"],

 	// The tsc compiler is started in watching mode
-	"isWatching": true,
+    "isBackground": true,



Formatting?

timmhirsens · 2017-06-05T09:15:11Z

src/elixirSenseDefinitionProvider.ts

+                }
+            });
+            */
+


Maybe delete this?

timmhirsens · 2017-06-05T09:15:17Z

src/elixirSenseHoverProvider.ts

+                }
+            });
+            */
+


Maybe delete this?

potterdai · 2017-06-05T13:45:19Z

Hi, just did all the follow up cleanings and changes.
The code was done in a bit rush last week so it lacks a bit cleaning, now it should be good.
Please report if there is any errors. Thank you! = )

timmhirsens · 2017-06-05T13:50:52Z

Okay, the Code is looking fine now ;-)

Hower I am having issues getting this to run. I checked out your changes, inited the submodule and did a clean npm install. I keep getting this error:

[vscode-elixir] Cannot decode Erlang term: <<131,116,0,0,0,3,119,5,101,114,114,111,114,119,3,110,105,108,119,7,112,97,121,108,111,97,100,116,0,0,0,3,119,14,97,99,116,117,97,108,95,115,117,98,106,101,99,116,109,0,0,0,8,67,97,104,46,71,97,109,101,119,4,100,111,99,115,116,0,0,0,3,119,9,99,97,108,108,98,97,99,107,115,109,0,0,0,0,119,4,100,111,99,115,109,0,0,0,26,78,111,32,100,111,99,117,109,101,110,116,97,116,105,111,110,32,97,118,97,105,108,97,98,108,101,119,5,116,121,112,101,115,109,0,0,0,0,119,7,115,117,98,106,101,99,116,109,0,0,0,8,67,97,104,46,71,97,109,101,119,10,114,101,113,117,101,115,116,95,105,100,97,6>>
Reason: RangeError: Offset is outside the bounds of the DataView
    at DataView.getUint8 (<anonymous>)
    at _decodeAtom (/home/timm/projects/vscode-elixir/out/src/jem.js:74:39)
    at _decodeObject (/home/timm/projects/vscode-elixir/out/src/jem.js:112:24)
    at _decodeValue (/home/timm/projects/vscode-elixir/out/src/jem.js:55:20)
    at Object.decode (/home/timm/projects/vscode-elixir/out/src/jem.js:18:16)
    at ElixirSenseClient.readPacket (/home/timm/projects/vscode-elixir/out/src/elixirSenseClient.js:58:30)
    at ElixirSenseClient.handleData (/home/timm/projects/vscode-elixir/out/src/elixirSenseClient.js:39:18)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)

Am I missing anything here?

potterdai · 2017-06-05T14:33:14Z

Hey, just decoded the Erlang term, the problem seems at jem.ts.
It's weird at my place all projects works fine.
Did you try with another project? Is the result the same?

potterdai · 2017-06-05T15:12:33Z

Fixed!
The bug is that the code I took from jem.js(https://github.com/inaka/jem.js) ignores atom type 118 and 119. Just fixed here, and I think I should make a pull request there as well = ).

timmhirsens · 2017-06-06T04:34:38Z

Yes, that bug seems fixed, great work!

I am going to compare both versions for a bit now, before i merge this.

timmhirsens · 2017-06-07T04:54:36Z

This seems to work really well, and I like the added Parameter Help!

Going to merge this now and publish a release later today / this week.

Again, thank you very (!) much for your contribution!

potterdai · 2017-06-07T05:10:36Z

Sure!
Also just a remind, please add the new configurations to the README file when do the publish.
https://github.com/fr1zle/vscode-elixir/blob/master/package.json#L148
Just in case somebody still prefer the original alchemist-server version, they can switch quite easily.

msaraiva · 2017-06-09T00:31:14Z

@potterdai @fr1zle Great job! It would be really nice if we could have a centralized repo for the customized jem.js and elixir-sense-client.js. This way, changes like this could benefit any JS based editor (like Atom). I guess we could have those two files in the elixir_sense project. We could then configure a package.json so we can publish it as an npm package. What do you think?

BTW. We could also include all needed .ex and .exs in the package. This way client and server files will always be in sync and we won't have to copy those files manually anymore ;)

potterdai · 2017-06-09T01:16:56Z

@msaraiva Sure, that's a great idea!
Could you create a new repo for jem.js and elixir-sense-client.js? Then I can make a pull request for the revised version of jem.js .

potterdai added 6 commits June 3, 2017 10:20

Implement ElixirSense.

9506725

Add build script.

321df58

Add vsce to dev dependencies.

8cbc14a

Update sorting method.

acf650c

Signature now can distinguish "// []" params.

cbfa0e6

Make autocomplete detail show function params.

29f513f

potterdai added 3 commits June 4, 2017 10:25

Use signature with closest arity if no signature matches.

aa44bd0

Fix not showing active param when param is '\\ []'

8dbe535

Fix signature slice bug.

539ab81

timmhirsens requested changes Jun 5, 2017

View reviewed changes

potterdai added 2 commits June 5, 2017 09:39

Fix and cleanning follow-up.

70f2ac4

More cleanup in AutocompleteProvider.

c474839

timmhirsens approved these changes Jun 5, 2017

View reviewed changes

Fix bug jem ignores atom type 118 & 119.

7a75847

timmhirsens merged commit aa10165 into timmhirsens:master Jun 7, 2017

timmhirsens mentioned this pull request Jun 7, 2017

Switch to ElixirSense #60

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement ElixirSense. #67

Implement ElixirSense. #67

potterdai commented Jun 3, 2017 •

edited

Loading

timmhirsens commented Jun 4, 2017

timmhirsens left a comment

timmhirsens Jun 5, 2017

timmhirsens Jun 5, 2017

potterdai Jun 5, 2017

timmhirsens Jun 5, 2017

timmhirsens Jun 5, 2017

timmhirsens Jun 5, 2017

potterdai commented Jun 5, 2017

timmhirsens commented Jun 5, 2017

potterdai commented Jun 5, 2017

potterdai commented Jun 5, 2017

timmhirsens commented Jun 6, 2017

timmhirsens commented Jun 7, 2017

potterdai commented Jun 7, 2017

msaraiva commented Jun 9, 2017

potterdai commented Jun 9, 2017

Implement ElixirSense. #67

Implement ElixirSense. #67

Conversation

potterdai commented Jun 3, 2017 • edited Loading

timmhirsens commented Jun 4, 2017

timmhirsens left a comment

Choose a reason for hiding this comment

timmhirsens Jun 5, 2017

Choose a reason for hiding this comment

timmhirsens Jun 5, 2017

Choose a reason for hiding this comment

potterdai Jun 5, 2017

Choose a reason for hiding this comment

timmhirsens Jun 5, 2017

Choose a reason for hiding this comment

timmhirsens Jun 5, 2017

Choose a reason for hiding this comment

timmhirsens Jun 5, 2017

Choose a reason for hiding this comment

potterdai commented Jun 5, 2017

timmhirsens commented Jun 5, 2017

potterdai commented Jun 5, 2017

potterdai commented Jun 5, 2017

timmhirsens commented Jun 6, 2017

timmhirsens commented Jun 7, 2017

potterdai commented Jun 7, 2017

msaraiva commented Jun 9, 2017

potterdai commented Jun 9, 2017

potterdai commented Jun 3, 2017 •

edited

Loading