support follower read #5051
Merged
support follower read #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
|
/run-all-tests |
overvenus
reviewed
Jul 9, 2019
nolouch
reviewed
Jul 9, 2019
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
overvenus
reviewed
Jul 10, 2019
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
Signed-off-by: 5kbpers <[email protected]>
overvenus
previously approved these changes
Jul 11, 2019
| cluster.must_transfer_leader(region.get_id(), p2.clone()); | ||
|
|
||
| // Block all write cmd applying of Peer 3. | ||
| fail::cfg("on_apply_write_cmd", "sleep(5000)").unwrap(); |
There was a problem hiding this comment.
How about pause? It works like sleep but blocks forever until turning it off.
There was a problem hiding this comment.
The apply thread could not exit after the assertion failed (before the fail point was turned off) if we use pause.
Signed-off-by: 5kbpers <[email protected]>
overvenus
reviewed
Jul 12, 2019
Signed-off-by: 5kbpers <[email protected]>
overvenus
approved these changes
Jul 16, 2019
|
/run-all-tests |
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* raftstore,server: support follower read Signed-off-by: 5kbpers <[email protected]> * raftstore: fix condition check of read on replica Signed-off-by: 5kbpers <[email protected]> * raftstore: follower read waits for apply index reaches read index Signed-off-by: 5kbpers <[email protected]> * add a test of waiting for read index Signed-off-by: 5kbpers <[email protected]> * fix test_wait_for_apply_index Signed-off-by: 5kbpers <[email protected]> * dec pending reads count after follower handle read index cmd Signed-off-by: 5kbpers <[email protected]> * update comments Signed-off-by: 5kbpers <[email protected]> * remove unused file Signed-off-by: 5kbpers <[email protected]> * fix test_wait_for_apply_index Signed-off-by: 5kbpers <[email protected]> * update comments Signed-off-by: 5kbpers <[email protected]> * update test_wait_for_apply_index Signed-off-by: 5kbpers <[email protected]> * update dependency 'kvproto' Signed-off-by: 5kbpers <[email protected]>
fredchenbj
pushed a commit
to fredchenbj/tikv
that referenced
this pull request
Mar 10, 2020
* raftstore,server: support follower read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers [email protected]
What have you changed? (mandatory)
This PR introduces a new feature, which enables clients to read data from follower peers.
We add a new RPC option
follower_readto structContextwithin every request, see 5kbpers/kvproto@e55978cWhat are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
integration tests
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
pingcap/kvproto#424