-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agate: refactor for memtable impl #37
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b57171e
agate: prepare for memtable and wal impl
skyzh 5183a95
fix compile error
skyzh a084447
format
skyzh d290a6e
fix warnings
skyzh f3e0b22
remove impls
skyzh 9683c84
fix warning
skyzh 636f611
Merge branch 'master' into refactor-for-memtable
skyzh 8b72bb1
format
skyzh 2502250
Merge branch 'refactor-for-memtable' of https://github.com/tikv/agate…
skyzh b621563
address comments
skyzh aa86661
Merge branch 'master' into refactor-for-memtable
skyzh 940c52d
remove agateoptions methods
skyzh 0607327
use mutex
skyzh e327656
Merge branch 'refactor-for-memtable' of https://github.com/tikv/agate…
skyzh 61b45e7
Merge branch 'master' into refactor-for-memtable
skyzh 089adc6
add all options
skyzh 2bed2a5
remove poison error
skyzh fd68fb6
fix ce
skyzh 5e7395a
resolve comments
skyzh 9ee5b23
revert decode
skyzh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
format
Signed-off-by: Alex Chi <[email protected]>
- Loading branch information
commit 8b72bb1074cc94f0864517dd98772a037865b412
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just
file.set_len(size)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function has been removed for now. We will directly call
set_len
onFile
, instead of creating this new function to handle that.