Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skiplist: Fix undefined behavior in arena drop #24

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

brson
Copy link
Contributor

@brson brson commented Oct 21, 2020

The Vec must be deallocated with the same pointer alignment and capacity as it
is created.

Signed-off-by: Brian Anderson [email protected]

Found with miri cc @RalfJung

The Vec must be deallocated with the same pointer alignment and capacity as it
is created.

Signed-off-by: Brian Anderson <[email protected]>
@BusyJay
Copy link
Member

BusyJay commented Oct 21, 2020

Perhaps we can also add miri check in CI.

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll add miri check later

@skyzh skyzh merged commit 8809021 into tikv:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants