-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: add bench action #173
Conversation
Signed-off-by: GanZiheng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 89.64% 89.47% -0.18%
==========================================
Files 39 39
Lines 8739 8739
==========================================
- Hits 7834 7819 -15
- Misses 905 920 +15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the output
Signed-off-by: GanZiheng <[email protected]>
a3e7611
to
ff11cd0
Compare
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
benches/benches_badger_rocks.rs
Outdated
opts.dir = dir_path.to_path_buf(); | ||
opts.value_dir = dir_path.to_path_buf(); | ||
|
||
c.bench_function("badger populate large value", |b| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should reuse the bench_badger
impl with value size as a variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I found we could not simply reuse them.
Signed-off-by: GanZiheng <[email protected]>
Seems we cannot do it 🤣 |
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
Signed-off-by: GanZiheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: GanZiheng [email protected]