Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memtable: update memtable view #154

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

GanZiheng
Copy link
Contributor

@GanZiheng GanZiheng commented Jun 15, 2022

Adjust MemTablesView to use vector to store all current memtables instead of a fixed length array.

This pull request will also resolve #152 from one aspect, which is the count of memtables exceeds MEMTABLE_VIEW_MAX.

Signed-off-by: GanZiheng [email protected]

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #154 (c7a8af2) into master (6b5c341) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   85.87%   85.85%   -0.02%     
==========================================
  Files          36       36              
  Lines        6745     6737       -8     
==========================================
- Hits         5792     5784       -8     
  Misses        953      953              

@zhangjinpeng87 zhangjinpeng87 merged commit 6972d08 into tikv:master Jun 15, 2022
zhangjinpeng87 pushed a commit to zhangjinpeng87/agatedb that referenced this pull request Jun 15, 2022
* update memtable view

Signed-off-by: GanZiheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running tests with code coverage is endless after switch compaction on
3 participants