Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagepath that was missing for elastic-curator #538

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

doublek
Copy link
Contributor

@doublek doublek commented Apr 23, 2020

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@bcreane
Copy link
Contributor

bcreane commented Apr 23, 2020

Not for this PR, but would be great to validate imagePath functionality in a UT.

@doublek doublek added enterprise Feature applies to enterprise only kind/bug Something isn't working labels Apr 23, 2020
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise Feature applies to enterprise only kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants