Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiInterfaceMode to installation spec #508

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add MultiInterfaceMode to installation spec #508

merged 1 commit into from
Apr 14, 2020

Conversation

Brian-McM
Copy link
Contributor

Description

This configures if multiple interfaces are allowed per pod and what configures them. We only allow multus for now.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. a few comments.

deploy/crds/operator_v1_installation_crd.yaml Outdated Show resolved Hide resolved
pkg/render/node.go Outdated Show resolved Hide resolved
@Brian-McM Brian-McM marked this pull request as ready for review April 13, 2020 19:57
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This configures if multiple interfaces are allowed per pod and what configures them. We only allow multus for now.
@Brian-McM Brian-McM merged commit a156d6b into tigera:master Apr 14, 2020
@Brian-McM Brian-McM deleted the bm-add-multi-interface-mode branch April 14, 2020 20:50
@caseydavenport caseydavenport added enterprise Feature applies to enterprise only kind/enhancement New feature or request labels Apr 15, 2020
@caseydavenport caseydavenport added this to the v1.5.0 milestone Apr 15, 2020
@caseydavenport
Copy link
Member

@tmjd double check I put the right milestone on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise Feature applies to enterprise only kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants