Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne_hw_monitor): allow max cloud angle of 360 degrees #50

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Aug 9, 2023

PR Type

  • Bug Fix

Related Links

Addresses issue #44

Description

Allows the minimum and maximum cloud angle parameters to be up to 360 degrees.
The hardware interface automatically converts a 360 degree value into 359 (previously implemented in #40).

Review Procedure

Launch the hardware monitor with cloud_min_angle and cloud_max_angle at the limits (0 and 360 degrees).

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz requested a review from amc-nu August 9, 2023 10:52
@drwnz drwnz self-assigned this Aug 9, 2023
@drwnz drwnz added the bug Something isn't working label Aug 9, 2023
@drwnz drwnz merged commit f82a6f8 into main Aug 10, 2023
10 of 11 checks passed
@drwnz drwnz deleted the fix/velodyne_hw_monitor_fov branch August 10, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants