remove warning from installChar() #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm we could export a C callable for it? I plan to release a new rlang version soon. |
|
That would probably be better than copying the function over. |
|
I'll merge this now, and replace later when/if a callable becomes available. |
romainfrancois
added a commit
that referenced
this pull request
Nov 19, 2020
…e bindings) (#5520) * + lazy_vec_chop() * + dplyr_data_masks() * stack imbalmance * + env_resolved() to query which promise has been resolved * install .indices for top mask and individual masks * DataMask holds chops and masks * use individual data masks instead of meta data mask that gets updated all the time * filter() internals also not using metamask * No longer using DataMask$mask * abandon DataMask$forget() * remove DataMask$bindings * Abandon DataMask$which_used * Remove DataMask$used, as it can be recalculated based on $chops and $resolved * Abandon DataMask$resolved, instead just keep track of DataMask$all_vars and rely on chops for resolvedness * rm lazy_vec_chop.R, as this is only ever used inside DataMask. Make the data mask and pronouns internally * register symbols * use callables for as_data_pronoun() and new_data_mask() instead of R callbacks. * top can be NULL * back to only one mask, with active bindings instead of promises * comment why the [] is needed * comments about the parent envirinments of $chops and $mask in DataMask * use VECTOR_PTR_RO() and STRING_PTR_RO() * DPLYR_MASK_EVAL() takes single rgument * reset all_vars on mutate(=NULL) * NEWS bullet * update comment * remove warning from installChar() (#5609) * remove warning from installChar()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is copied from https://github.com/r-lib/rlang/blob/898449d00b51ac32839715be0bdd8c5330f56aca/src/lib/vec-chr.h#L92
@lionel- is there a way to use something like
r_str_as_symboldirectly from rlang ?