Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve row names in mutate #5503

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Preserve row names in mutate #5503

merged 4 commits into from
Nov 12, 2020

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 28, 2020

Fixes #5418

DavisVaughan
DavisVaughan approved these changes Aug 31, 2020
View reviewed changes
tests/testthat/test-generics.R Outdated Show resolved Hide resolved
tests/testthat/test-mutate.r Outdated Show resolved Hide resolved
@romainfrancois
Copy link
Member

I'll leave it to you to squash it @hadley as it's originally yours.

@hadley hadley merged commit 6307231 into master Nov 12, 2020
@hadley hadley deleted the rownames branch November 12, 2020 12:47
@dchiu911 dchiu911 mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainfrancois romainfrancois romainfrancois approved these changes

@DavisVaughan DavisVaughan DavisVaughan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutate Drops Row Names
4 participants
@hadley @romainfrancois @DavisVaughan @cathblatter