Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data masking of tidyselect env-expressions in across() #5475

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Fix data masking of tidyselect env-expressions in across() #5475

merged 3 commits into from
Aug 12, 2020

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Aug 11, 2020

Follow-up to #5469
Closes #5460

romainfrancois
romainfrancois approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@romainfrancois romainfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That looks more solid than my previous approach.

@romainfrancois romainfrancois added this to the 1.0.2 milestone Aug 12, 2020
@lionel- lionel- merged commit 8f3a482 into tidyverse:master Aug 12, 2020
@lionel- lionel- deleted the fix-across-mask branch August 12, 2020 12:12
@lionel- lionel- mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainfrancois romainfrancois romainfrancois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

across(all_of(y)) fails if data contains column "y"
2 participants
@lionel- @romainfrancois