Refactor encoding test helpers and use withr::local_locale() #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
commented
May 12, 2020
| "en_US.ISO8859-1", | ||
| "en_US.ISO8859-15", | ||
| "fr_CH.ISO8859-1", | ||
| "fr_CH.ISO8859-15" |
There was a problem hiding this comment.
We could add more if we see skips on a system where there are non-UTF-8 locales available.
romainfrancois
approved these changes
May 12, 2020
There was a problem hiding this comment.
Thanks. I think I confused myself to not use withr:: because we don't use it in the code and only Suggests it, but that's nicer.
closes #5231
|
I saw withr is already used elsewhere below |
lionel-
reviewed
May 14, 2020
| @@ -53,7 +53,9 @@ DataMask <- R6Class("DataMask", | |||
|
|
|||
| promises <- map(seq_len(ncol(data)), function(.x) expr(promise_fn(!!.x))) | |||
|
|
|||
| env_bind_lazy(private$bindings, !!!set_names(promises, names_bindings)) | |||
| suppressWarnings( | |||
There was a problem hiding this comment.
Also it needs a comment about the kind of anticipated warnings. Also if this needs to be fixed here it might need to be fixed upstream.
There was a problem hiding this comment.
This is from @romainfrancois. I had asked a similar question in slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #5231. withr does have support for locale change, so I used that + some probing for a non-UTF-8 locale.