Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tidyselect docs #5221

Merged
merged 8 commits into from
May 12, 2020
Merged

Update tidyselect docs #5221

merged 8 commits into from
May 12, 2020

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented May 11, 2020

  • Import upstream documentation.

  • Switch to where().

@lionel- lionel- requested a review from hadley May 11, 2020 09:18
hadley
hadley approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to add any new remotes to dplyr right now, so we can merge when tidyselect is on CRAN.

@lionel- lionel- merged commit 1227423 into tidyverse:master May 12, 2020
@lionel- lionel- deleted the doc-tidyselect branch May 12, 2020 09:09
@lionel-
Copy link
Member Author

lionel- commented May 12, 2020

I had to embed the tidyselect documentation after all, because of this issue with inherited sections: r-lib/roxygen2#1097

And because I made a mistake with the overview Rmd file which is not installed in inst/ as it should. I'll make a note to fix it once these issues are solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel- @hadley