Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various errors fixes #5197

Merged
merged 11 commits into from
May 6, 2020
Merged

Various errors fixes #5197

merged 11 commits into from
May 6, 2020

Conversation

romainfrancois
Copy link
Member

full stops, back ticks ...

lionel-
lionel- approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple remaining issues.

tests/testthat/test-context-error.txt Outdated Show resolved Hide resolved
tests/testthat/test-count-tally-errors.txt Outdated Show resolved Hide resolved
tests/testthat/test-distinct-errors.txt Outdated Show resolved Hide resolved
@romainfrancois romainfrancois merged commit 4dd718f into master May 6, 2020
@romainfrancois romainfrancois deleted the errors_typos branch May 6, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel- lionel- lionel- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainfrancois @lionel-