Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-buildignore files named bench #4985

Merged
merged 3 commits into from
Mar 15, 2020
Merged

Un-buildignore files named bench #4985

merged 3 commits into from
Mar 15, 2020

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 14, 2020

What a funny bug.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 15, 2020

deprec-bench-compare.r was build-ignored because bench was in .Rbuildignore, and consequently ignored by roxygenize(). This fixes a bunch of dbplyr tests and perhaps other downstream packages.

@hadley hadley merged commit 2cc0a75 into tidyverse:master Mar 15, 2020
@hadley
Copy link
Member

hadley commented Mar 15, 2020

Thanks!

sthagen added a commit to sthagen/tidyverse-dplyr that referenced this pull request Mar 15, 2020
@sthagen
Merge pull request #26 from tidyverse/master
9086aa8 
Un-buildignore files named bench (tidyverse#4985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainfrancois romainfrancois Awaiting requested review from romainfrancois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley