-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summarise() works for empty data frames #3274
summarise() works for empty data frames #3274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’d be useful to add a test for mean()
too. In general, I’m not sure if the hybrid handlers have been written with an eye to the zero length case.
Indeed, |
I'm seeing an average 10% slowdown with this PR with I've started a writeup, http://rpubs.com/krlmlr/dplyr-spec-template, would that be suitable as an internal dplyr vignette? |
Update: A second measurement with
|
0d22c56
to
54b8191
Compare
because this is brittle and often fails on Windows
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Fixes #3071.