Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement top_n() lazily #2859

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Implement top_n() lazily #2859

merged 1 commit into from
Jun 14, 2017

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Jun 13, 2017

Closes #2848

@javierluraschi sparklyr now creates this request with your reprex:

Selecting by  X
<SQL> SELECT `X`
FROM (SELECT `X`, rank() OVER (ORDER BY `X` DESC) AS `zzz2`
FROM `test_data`) `kmanvoxmpk`
WHERE (`zzz2` <= 10.0)

@javierluraschi
Copy link
Contributor

Looks good!

BTW. I already pushed a patch to CRAN for sparklyr and top_n, so no need rush this into CRAN, I'll revert the sparklyr patch after dplyr updates in CRAN.

@lionel- lionel- merged commit 81cef2e into tidyverse:master Jun 14, 2017
@lionel- lionel- deleted the fix-top-n-2648 branch November 7, 2017 10:17
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants